-
Notifications
You must be signed in to change notification settings - Fork 8
Closes #409 updated scorres to scstresc #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @vbshuliar - we should also update the tests within https://github.com/pharmaverse/sdtmchecks/tree/devel/tests/testthat |
Also may need to see what the source of the details for our checks for on this page - https://pharmaverse.github.io/sdtmchecks/articles/search_checks.html |
Hi reviewers, |
Hi @vbshuliar - you may notice that there is a check failing for R CMD Check - this is identifying we've not updated a global variable for |
Hi @barnett11 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vbshuliar , some suggested updates thank you,
check_sc_dm_seyeselc
description suggestsOU
should be an option, but actually it is not - please update description- Please also make same update of
SCORRES
toSCSTRESC
for checkscheck_ec_sc_lat
andcheck_oe_sc_lat_count_fingers
Thanks
Hi @barnett11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good thank you @vbshuliar !
@harriscw - would you like to review before we merge to |
Summary:
This PR updates the checks check_sc_dm_eligcrit and check_sc_dm_seyeselc to replace all references of SCORRES with SCSTRESC as per the new requirements.
Changes:
Updated references of SCORRES to SCSTRESC in the following checks:
Testing:
Verified that the updated checks function correctly with SCSTRESC.