Improve Iceberg opening management #18452
Open
+5
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change follows a change in Iceberg. The goal is that when we open Iceberg, if it is already open we bring it to the front because we should not need multiple icebergs
Ducasse
reviewed
Aug 12, 2025
| a model." | ||
| ((Smalltalk at: #IceTipRepositoriesBrowser) new) open ] | ||
| (Smalltalk at: #IceTipRepositoriesBrowser) ensureIsOpen ] |
There was a problem hiding this comment.
We should use self application tools toolNamed: something.
There was a problem hiding this comment.
For now there are no registration for Iceberg in the tool registry.
It's probably something we should add but it's not there yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change follows a change in Iceberg.
The goal is that when we open Iceberg, if it is already open we bring it to the front because we should not need multiple icebergs