Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a space before the </s> tag for assistant messages #14

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

mukundt
Copy link
Contributor

@mukundt mukundt commented Aug 22, 2023

According to the Hugging Face Llama 2 prompt template guide, there should be a space after the assistant message, right before the </s> tag.

Copy link
Owner

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing

@philschmid philschmid merged commit 01c80c4 into philschmid:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants