Skip to content

build.sh: use per-project compilation database location #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

nalajcie
Copy link
Member

Fix problems with host-tools building and phoenix-builder calling.

JIRA: CI-504

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: NIL

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Fix problems with host-tools building and phoenix-builder calling.

JIRA: CI-504

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Not following: ./build.project: openBinaryFile: does not exist (No such file or directory) SC1091

source ./build.project

Copy link

Unit Test Results

7 725 tests  ±0   7 010 ✅ ±0   37m 17s ⏱️ - 1m 40s
  445 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit c79d67d. ± Comparison against base commit 68a2af8.

Copy link
Member

@anglov anglov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: it creates empty symlink in our build system. I think it not break anything

@nalajcie
Copy link
Member Author

Note: it creates empty symlink in our build system. I think it not break anything

You mean - symlink to nonexisting file? That's ok for me, if you call build.sh via bear the target file would be created in the desired location.

@nalajcie nalajcie merged commit dfc551a into master Oct 11, 2024
34 checks passed
@nalajcie nalajcie deleted the nalajcie/bear branch October 11, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants