Skip to content

image_builder: fix blob command #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2024
Merged

image_builder: fix blob command #212

merged 2 commits into from
Oct 16, 2024

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Oct 16, 2024

Description

  • image_builder: fix blob command
  • image_builder: small typing/linter fixes

Motivation and Context

JIRA: CI-494

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link

github-actions bot commented Oct 16, 2024

Unit Test Results

7 741 tests  +16   7 026 ✅ +16   41m 11s ⏱️ + 4m 5s
  461 suites +16     715 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit c3163e3. ± Comparison against base commit dfc551a.

♻️ This comment has been updated with latest results.

ziemleszcz
ziemleszcz previously approved these changes Oct 16, 2024
Copy link

@ziemleszcz ziemleszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK except debug print and one extra space before data map.

@nalajcie
Copy link
Member Author

Looks OK except debug print and one extra space before data map.

I've noticed the extra space but couldn't think of not over-complicated way to remove it (and plo didn't have problem).

I've proposed some solution (with extra comment to avoid removing it in the future).

@nalajcie nalajcie merged commit 9624fa5 into master Oct 16, 2024
36 checks passed
@nalajcie nalajcie deleted the nalajcie/image_blob_fix branch October 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants