Skip to content

image builder: allow passing commands directly by using % prefix #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

image builder: allow passing commands directly by using % prefix #213

merged 1 commit into from
Oct 17, 2024

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Oct 17, 2024 •
edited
Loading

Description

With this change you can hand-craft commands which normally would be parsed by image_builder.py, eg:

%app flash0 -x psh;-i;/etc/rc.psh ddr ddr;nonexistent (will not generate corresponding alias, will not add psh to the target image automatically)

This usage is discouraged and should be used only in testing and some extremely hackish use cases.

Motivation and Context

JIRA: CI-494

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: NIL

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@nalajcie
image builder: allow passing commands directly by using % prefix
c0b1416 
With this change you can hand-craft commands which normally would be
parsed by `image_builder.py`, eg:

%app flash0 -x psh;-i;/etc/rc.psh ddr ddr;nonexistent
(will not generate corresponding `alias`, will not add `psh` to the
target image automatically)

This usage is discouraged and should be used only in testing and some
extremely hackish use cases.

JIRA: CI-494
@github-actions GitHub Actions
Copy link

Unit Test Results

7 741 tests  ±0   7 026 ✅ ±0   41m 35s ⏱️ +19s
  461 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit c0b1416. ± Comparison against base commit 9624fa5.

@nalajcie nalajcie merged commit 6cab908 into master Oct 17, 2024
36 checks passed
@nalajcie nalajcie deleted the nalajcie/image_builder_raw_command branch October 17, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziemleszcz ziemleszcz ziemleszcz approved these changes

@Darchiv Darchiv Awaiting requested review from Darchiv

@anglov anglov Awaiting requested review from anglov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalajcie @ziemleszcz