Skip to content

image_builder: allow passing offset as numeric value #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

lukileczo
Copy link
Member

JIRA: RTOS-956

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link

Unit Test Results

6 859 tests   - 882   6 229 ✅  - 797   37m 52s ⏱️ - 1m 52s
  405 suites  -  56     629 💤  -  86 
    1 files   ±  0       1 ❌ +  1 

For more details on these failures, see this check.

Results for commit f2e3e33. ± Comparison against base commit 6cab908.

This pull request removes 922 and adds 40 tests. Note that renamed tests count towards both.
phoenix-rtos-tests/cpp/hello-cpp ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/cpp/hello-cpp
phoenix-rtos-tests/initfini/main ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/initfini/main
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.in_val
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.invalid_req
…
phoenix-rtos-tests/libc/unix-socket ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.accept_connect_async
phoenix-rtos-tests/libc/unix-socket ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.accept_connect_errnos
phoenix-rtos-tests/libc/unix-socket ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.accept_connect_liveness
phoenix-rtos-tests/libc/unix-socket ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.recv_msg_peek
phoenix-rtos-tests/libc/unix-socket ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.accept_connect_async
phoenix-rtos-tests/libc/unix-socket ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.accept_connect_errnos
phoenix-rtos-tests/libc/unix-socket ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.accept_connect_liveness
phoenix-rtos-tests/libc/unix-socket ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.recv_msg_peek
phoenix-rtos-tests/libc/unix-socket ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.accept_connect_async
phoenix-rtos-tests/libc/unix-socket ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.accept_connect_errnos
…
This pull request removes 89 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.
phoenix-rtos-tests/libc/exit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/exit.unistd_Exit.unblock_thread_wait
phoenix-rtos-tests/libc/exit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/exit.unistd_Exit.unblock_thread_waitpid
phoenix-rtos-tests/libc/exit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/exit.unistd_exit.unblock_thread_wait
phoenix-rtos-tests/libc/exit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/exit.unistd_exit.unblock_thread_waitpid
phoenix-rtos-tests/libc/misc ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/misc.ctype._tolower
phoenix-rtos-tests/libc/misc ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/misc.ctype._toupper
phoenix-rtos-tests/libc/misc ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/misc.ctype.toascii
phoenix-rtos-tests/libc/misc ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/misc.resolve_path.realpath_max_path
phoenix-rtos-tests/libc/misc ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/misc.stat_errno.enotdir
phoenix-rtos-tests/libc/misc ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/misc.stat_mode.chr_type
…
phoenix-rtos-tests/libc/unix-socket ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.accept_connect_liveness
phoenix-rtos-tests/libc/unix-socket ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.accept_connect_liveness
phoenix-rtos-tests/libc/unix-socket ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/unix-socket.test_unix_socket.accept_connect_liveness

@lukileczo lukileczo merged commit e268324 into master Oct 21, 2024
35 of 36 checks passed
@lukileczo lukileczo deleted the lukileczo/rtos-956 branch October 21, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants