Makefile.common: add -Wundef #233
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @anglov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello! gemini-code-assist here, providing a summary of this pull request to help everyone quickly understand the changes and current status.
The primary goal of this PR, as indicated by the title and description, is to enhance the build system's warning level by adding the -Wundef compiler flag to both C and C++ compilation options. This flag helps catch potential issues where undefined preprocessor macros are used, promoting better code quality and preventing subtle bugs.
The changes are focused on the Makefile.common file, specifically modifying the CFLAGS and CXXFLAGS variables to include the new warning flag. This is a straightforward change aimed at improving code hygiene across the project.
Highlights
- Add -Wundef compiler flag: The core change is the addition of the
-Wundefflag to bothCFLAGSandCXXFLAGSinMakefile.common. This flag warns about the use of undefined identifiers in#ifdirectives, which can lead to unexpected behavior. - Improve code quality: By enabling
-Wundef, the build process will now catch potential issues related to undefined preprocessor macros, aligning with practices used in internal projects and contributing to overall code robustness.
Changelog
- Makefile.common
- Added
-Wundefflag toCFLAGSandCXXFLAGSto enable warnings for undefined preprocessor macros.
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces the -Wundef flag to the CFLAGS and CXXFLAGS in the Makefile.common. This is a good step towards enabling more useful warning flags. The change is straightforward and seems well-motivated. Here are some comments.
Merge Readiness
The addition of -Wundef is a positive step towards improving code quality by enabling more compiler warnings. The change is simple and well-motivated. I am unable to approve the pull request, and users should have others review and approve this code before merging. There are no critical or high severity issues, so this pull request is ready to be merged.
Description
There are some useful warning flags, which are enabled in internal projects, like -Wundef and -Wshadow.
This commit adding
-Wundefto our build systemMotivation and Context
Enable
-WundefTypes of changes
How Has This Been Tested?
Checklist:
Special treatment