!Makefile.common: add -Werror #234
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @nalajcie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a significant change to the build system by enabling the -Werror flag for C and C++ compilations. The primary goal is to enforce stricter code quality and catch potential issues early in the continuous integration pipeline, ensuring that all warnings are addressed as errors. This is a breaking change for any existing codebases that currently compile with warnings.
Highlights
- Stricter Compilation Enforcement: The
-Werrorflag has been added to bothCFLAGSandCXXFLAGSinMakefile.common, which will now treat all compiler warnings as errors, causing builds to fail if any warnings are present. - Impact on Code Quality: This change aims to improve overall code quality by preventing code with warnings from being merged, ensuring that developers address potential issues proactively and catch problems early in the CI pipeline.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Can be used to use extra compliation flags on per-project basis. JIRA: CI-556
Potentially breaking - if forks contain code with warnings. How to fix: fix your code - or add USER_CFLAGS=-Wno-error to the project file. JIRA: CI-556
nalajcie
force-pushed
the
nalajcie/werror
branch
from
056a8f0 to
aa0960f
Compare
Description
USER_CFLAGS/USER_CXXFLAGSto override CFLAGS on per-project basis.Potentially breaking - if forks contain code with warnings.
How to fix: fix your code - or add
USER_CFLAGS=-Wno-errorto the project file.JIRA: CI-556
Types of changes
How Has This Been Tested?
Checklist:
Special treatment