WIP: Update tailwind to version 4.0.0#5990
WIP: Update tailwind to version 4.0.0#5990leifmetcalf wants to merge 1 commit intophoenixframework:mainfrom
Conversation
|
@Flo0807 mentioned in the related issue that the plugin works if it is directly exported as function: phoenixframework/tailwind#107 (comment) I verified that it works, but I'm hesitant to rely on this. v4 doesn't really document how plugins should look like so that could change. I think if we wait for tailwindlabs/tailwindcss#15934, we should be good! |
leifmetcalf
force-pushed
the
tailwind-v4
branch
2 times, most recently
from
51b9450 to
59e1743
Compare
leifmetcalf
force-pushed
the
tailwind-v4
branch
from
59e1743 to
9255040
Compare
| @variant phx-change-loading ([".phx-change-loading&", ".phx-change-loading &"]); | ||
| @theme { | ||
| --color-brand: "#FD4F00", | ||
| }; |
There was a problem hiding this comment.
@leifmetcalf I just tested this again with Tailwind 4.0.6 and the plugin seems to work now. The only issue I had was that Tailwind complained Error: Unexpected semicolon until I removed the semicolon after @theme {};.
There was a problem hiding this comment.
sorry, false alarm. I still had a node_modules folder lying around in a parent directory. So the plugin is still broken, but we need to fix the semicolon nonetheless.
|
Closing in favor of #6109 |
|
Thank you! @leifmetcalf |
5 participants
This is waiting on the elixir library being updated to support tailwind v4 in phoenixframework/tailwind#103.
Things I'm not sure about:
assets/css/tailwind_heroicons.js, but I'm not sure about the name and I don't think it belongs inassets/css. Also, for now, the tailwind standalone cli doesn't bundle the javascript library, so the heroicons plugin fails to load without runningnpm install tailwindcssor similar. See [v4] Standalone cli doesn't bundle tailwindcss js library tailwindlabs/tailwindcss#15235.