Update Node Deps #6283
Merged
Update Node Deps #6283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Can you please revert the changes to the priv directory in the PR? Those get built by CI automatically :) |
maennchen
force-pushed
the
jm/update-node-deps
branch
from
a87aa3b to
9fe4808
Compare
|
@SteffenDE Sure, that makes sense. I've pushed it without. |
|
🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
While scanning phoenix for known vulnerabilities, I found two in the node dependencies:
Since they are only in the build tooling, they don't result in any actual security issues. I still thought it would be good to do a quick update on the Node tooling.
Changes
@stylistic/eslint-plugin-js(deprecated) to@stylistic/eslint-plugin