Add type definitions for public interfaces #3789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteffenDE
force-pushed
the
sd-typescript
branch
3 times, most recently
from
19c8b4c to
d6121cb
Compare
SteffenDE
commented
May 9, 2025
| "types": "./assets/js/types/index.d.ts", | ||
| "dependencies": { | ||
| "morphdom": "2.7.5" | ||
| "morphdom": "git+https://github.com/SteffenDE/morphdom.git#sd-fix-ts" |
Collaborator
Author
There was a problem hiding this comment.
This got a bit bigger than expected, but it addresses multiple things: 1. includes type definitions for all public methods and interfaces. No need for `@types/phoenix_live_view`. The exported types are compatible with the currently documented type hints. Editors like VSCode now show detailed Intellisense. 2. rewrites some files in Typescript 3. updates eslint configuration to handle typescript 4. includes #3763 5. changes all commonjs files to modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got a bit bigger than expected, but it addresses multiple things:
@types/phoenix_live_view. The exported types are compatible with the currently documented type hints. Editors like VSCode now show detailed Intellisense.Sadly, eslint ended up rewriting many
lets toconsts while I was changing the config, but I didn't notice so it's hard to undo now, but the change is fine; it just makes things harder to review :(Closes #3361.