Handle missing component CIDs in resolve_components_xrefs#4166
Open
lunks wants to merge 1 commit intophoenixframework:mainfrom
Open
Handle missing component CIDs in resolve_components_xrefs#4166lunks wants to merge 1 commit intophoenixframework:mainfrom
lunks wants to merge 1 commit intophoenixframework:mainfrom
Conversation
resolve_components_xrefs/2 crashes with CaseClauseError when a component CID is removed between diff cycles (e.g. during stream resets) but still referenced via cross-reference pointers. This handles three cases: direct missing target, chain resolution where the intermediate target is removed recursively, and CID missing from the components map entirely. Related to phoenixframework#1247.
Collaborator
|
It feels like this does not solve the underlying problem, but instead treats the symptoms. If LiveView thinks it can reuse the component's statics, it seems reasonable to fail if it cannot as that's unexpected. The fix should be to ensure that LiveView cannot reuse a stale component in a diff. Do you have something that consistently reproduces this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_components_xrefs/2crashes withCaseClauseErrorwhen a component CIDis removed between diff cycles but still referenced via
:scross-reference pointers.This can happen during stream resets where components are removed and re-added across
two diff cycles, leaving stale CID references.
Three cases are now handled gracefully instead of crashing:
removes the intermediate target
Related to #1247.