Skip to content

Fix the misattributed root cause of broken tests#204

Merged
josevalim merged 1 commit intophoenixframework:mainfrom
plastic-forks:zd/improve-test
Dec 2, 2025
Merged

Fix the misattributed root cause of broken tests#204
josevalim merged 1 commit intophoenixframework:mainfrom
plastic-forks:zd/improve-test

Conversation

@zekedou
Copy link
Contributor

@zekedou zekedou commented Dec 2, 2025

Although the CI was fixed by #203, the attribution was incorrect.

The cause should be the Elixir version - a feature of registry introduced in Elixir v1.19, rather than the Erlang/OTP version.

This PR fixes it.

Copy link
Contributor

@SteffenDE SteffenDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@josevalim josevalim merged commit 6ff3cd4 into phoenixframework:main Dec 2, 2025
2 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@zekedou zekedou deleted the zd/improve-test branch December 3, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants