fix: use :peer for cluster tests#207
Merged
josevalim merged 6 commits intophoenixframework:mainfrom Feb 5, 2026
Merged
Conversation
This is logging a warning on Elixir 1.19.3
davydog187
commented
Feb 5, 2026
Contributor
|
I guess we can increase the minimum required elixir version |
Member
|
Yes, let's bump both Erlang and Elixir and we can ship it. |
Contributor
Author
|
@josevalim i copied over the CI workflow from phoenix live view and changed the minimum supported version to OTP 25, which is the earliest that supports For the library itself, I see no reason to change since this is just a test dependency. Let me know if you want to change, its currently Elixir 1.6 |
josevalim
reviewed
Feb 5, 2026
Member
|
If we don't test it on v1.6, then we shouldn't say we support it. We can likely update it to |
Co-authored-by: José Valim <jose.valim@gmail.com>
Contributor
Author
|
@josevalim done |
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is logging a warning on Elixir 1.19.3