non-static QueueSubscriberInterface::getSubscribedQueues() #1249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to make this accessor non-static to allow developers build more flexible mechanism of subscription. For example I have code:
where
getSubscribedQueues()is implemented by child classes.In my project I want to introduce
EventProcessorInterface, which can process events data mapped toeventModel()consideringgetSubscribedEvents(): string[]. But I cannot INJECTEventProcessorInterfacetoAbstractConsumerand delegateQueueSubscriberInterface::getSubscribedQueues()toEventProcessorInterface::getSubscribedEvents()because it is static method!