Skip to content

[RFC] Add RFC 3986 and WHATWG compliant URL parsing support#14461

Closed
kocsismate wants to merge 26 commits intophp:masterfrom
kocsismate:ext-url2
Closed

[RFC] Add RFC 3986 and WHATWG compliant URL parsing support#14461
kocsismate wants to merge 26 commits intophp:masterfrom
kocsismate:ext-url2

Conversation

@kocsismate
Copy link
Member

@kocsismate kocsismate commented Jun 3, 2024

2nd take after the failed experiment with #11315

RFC: https://wiki.php.net/rfc/url_parsing_api

@kocsismate kocsismate force-pushed the ext-url2 branch 5 times, most recently from 823e4c6 to e65deb7 Compare June 6, 2024 08:23
@kocsismate kocsismate changed the title Add ext/url based on Lexbor [RFC] Add ext/url based on Lexbor Jun 12, 2024
@TimWolla
Copy link
Member

I've just discussed with @kocsismate that this PR will likely be further split into separate PRs, since the size of the PR is giving me some troubles with GitHub's UI being laggy and also because GitHub already starts collapsing the comments.

Something like:

  • ext/lexbor additions
  • ext/uri skeleton (basic stub for exceptions, the vendored uriparser extension, ...)
  • Then the actual logic.

@kocsismate
Copy link
Member Author

I'm closing this PR as the majority of changes have already been merged as listed in #14461 (comment). The only notable exception is the withers of RFC 3986 implementation, but those require a full rework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants