JIT: Check exception on exit #18297
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| --TEST-- | ||
| GH-18262 001 (Assertion failure Zend/zend_vm_execute.h JIT) | ||
| --CREDITS-- | ||
| YuanchengJiang | ||
| --FILE-- | ||
| <?php | ||
| #[AllowDynamicProperties] | ||
| class B { | ||
| public int $fusion; | ||
| } | ||
| class C extends B { | ||
| } | ||
| class D extends C { | ||
| public function __destruct() { | ||
| } | ||
| } | ||
| $tests = [ | ||
| [C::class, new C()], | ||
| [C::class, new B()], | ||
| [D::class, new B()], | ||
| ]; | ||
| foreach ($tests as [$class, $instance]) { | ||
| $obj = (new ReflectionClass($class))->newLazyProxy(function ($obj) use ($instance) { | ||
| $instance->b = 1; | ||
| return $instance; | ||
| }); | ||
| var_dump($obj->b); | ||
| } | ||
| ?> | ||
| --EXPECTF-- | ||
| int(1) | ||
| int(1) | ||
|
|
||
| Fatal error: Uncaught TypeError: %s in %s:%d | ||
| Stack trace: | ||
| #0 {main} | ||
| thrown in %s on line %d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --TEST-- | ||
| GH-18262 002 (Assertion failure Zend/zend_vm_execute.h JIT) | ||
| --FILE-- | ||
| <?php | ||
| #[AllowDynamicProperties] | ||
| class B { | ||
| public function __construct($init) { | ||
| if ($init) { | ||
| $this->b = $init; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| $tests = [ | ||
| new B(1), | ||
| new B(0), | ||
| ]; | ||
|
|
||
| set_error_handler(function ($_, $errstr) { | ||
| throw new \Exception($errstr); | ||
| }); | ||
|
|
||
| foreach ($tests as $obj) { | ||
| var_dump($obj->b); | ||
| } | ||
| ?> | ||
| --EXPECTF-- | ||
| int(1) | ||
|
|
||
| Fatal error: Uncaught Exception: Undefined property: B::$b in %s:%d | ||
| Stack trace: | ||
| #0 %s(%d): {closure:%s:%d}(2, 'Undefined prope...', '%s', %d) | ||
| #1 {main} | ||
| thrown in %s on line %d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| --TEST-- | ||
| GH-18262 003 (Assertion failure Zend/zend_vm_execute.h JIT) | ||
| --FILE-- | ||
| <?php | ||
| #[AllowDynamicProperties] | ||
| class B { | ||
| public function __construct($init) { | ||
| if ($init) { | ||
| $this->b = $init; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| $tests = [ | ||
| new B(1), | ||
| new B('str'), // slow deoptimization, create linked side trace | ||
| new B(0), // jump to side trace with fast deoptimization | ||
| ]; | ||
|
|
||
| set_error_handler(function ($_, $errstr) { | ||
| throw new \Exception($errstr); | ||
| }); | ||
|
|
||
| foreach ($tests as $obj) { | ||
| try { | ||
| var_dump($obj->b); | ||
| } catch (Exception $e) { | ||
| printf("%s: %s\n", $e::class, $e->getMessage()); | ||
| } | ||
| } | ||
| ?> | ||
| --EXPECT-- | ||
| int(1) | ||
| string(3) "str" | ||
| Exception: Undefined property: B::$b |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| --TEST-- | ||
| GH-18262 004 (Assertion failure Zend/zend_vm_execute.h JIT) | ||
| --FILE-- | ||
| <?php | ||
| class B { | ||
| public function __construct( | ||
| public $throw, | ||
| ) { } | ||
| public function __get($name) { | ||
| return $this->throw === '1' ? 'str' : 1; | ||
| } | ||
| public function __destruct() { | ||
| if ($this->throw === '1') { | ||
| throw new Exception(__METHOD__); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| $tests = [ | ||
| '0', | ||
| '1', | ||
| ]; | ||
|
|
||
| foreach ($tests as $test) { | ||
| // Second iteration exits, and free op1 throws | ||
| var_dump((new B($test))->b); | ||
| } | ||
| ?> | ||
| --EXPECTF-- | ||
| int(1) | ||
|
|
||
| Fatal error: Uncaught Exception: B::__destruct in %s:%d | ||
| Stack trace: | ||
| #0 %s(%d): B->__destruct() | ||
| #1 {main} | ||
| thrown in %s on line %d |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also make sure this gets printed out in
zend_jit_dump_exit_info?