fix: Grid table termination and test suite modernization #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables now correctly terminate when followed by non-table content without requiring a blank line separator. - Add isTableRowLine() helper to detect valid table rows - Table ends when separator is followed by non-table content - Remove obsolete PHPStan ignore for unreachable statement
The variable was assigned but never read.
This data provider was never referenced by any test method.
Tests that grid tables are parsed correctly when they end at EOF without a trailing blank line.
Tests that grid tables terminate correctly when followed by whitespace-prefixed text that is not a table row.
PHPUnit 10+ does not support multiple DataProvider attributes on a single test method. This creates a combined tableCreationProvider that yields from all three individual providers. Also adds missing return type docblocks to the row span and column span providers for PHPStan compliance.
PHPUnit assertions provide better failure messages and are not affected by assert() being disabled in php.ini.
Verifies that the table parser correctly terminates when another table follows immediately without a blank line separator.
Verifies that the table parser correctly terminates when a reStructuredText directive follows immediately after the table.
Renamed to isDefinitionLine (added missing 'i').
Removed outdated comment about broken table cases (tests pass). Also fixed @param type for headers to list<TableRow> since it can be empty.
CybotTM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Bug Fix
Grid tables previously required a trailing blank line to terminate correctly. When text or other RST content immediately followed a table, the parser would either:
Solution: Added
isTableRowLine()helper that checks if the next line starts with|(after trimming whitespace). The termination logic now breaks when the next line is either empty OR not a valid table row.Test Suite Modernization
#[DataProvider]attributes with combined provider (PHPUnit 10+ compatibility)assert()withassertInstanceOf()for better failure messagesCode Cleanup
isDefintionLine→isDefinitionLine$headerRowsvariablegridTableFollowUpTextProviderdata provider$headersparameter (list<TableRow>instead ofnon-empty-list)Test Plan