Support methods prefixed with underscore#553
Open
neclimdul wants to merge 1 commit intophpspec:masterfrom
Open
Support methods prefixed with underscore#553neclimdul wants to merge 1 commit intophpspec:masterfrom
neclimdul wants to merge 1 commit intophpspec:masterfrom
Conversation
Member
|
I wonder if we'd need to do this in a major or not? I guess nobody's relying on 'methods that can't be mocked'? |
I don't think this warrants a new major either, this behavior shouldn't make a change to anyone actually writing tests. |
Fixes phpspec#108 While it was a common convention to prefix "private" methods with an underscore in earlier version of php, with support for method visibility this is no longer common. Additionally there are a number of exception such as the Soap library where this convention did not hold and code was not mockable.
neclimdul
force-pushed
the
support_mocking_underscore_methods
branch
from
c9d1655 to
219e572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
While it was a common convention to prefix "private" methods with an underscore
in earlier version of php, with support for method visibility this is no longer
common.
Additionally there are a number of exception such as the Soap library where
this convention did not hold and code was not mockable.