sidebar: use label-primary for num_gravity and num_lists

[XhmikosR]

Makes things consistent since these can contain both allowed and blocked domains/lists

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

1. Base your code and PRs against the repositories developmental branch.
2. Sign Off all commits as we enforce the DCO for all contributions
3. Sign all your commits as they must have verified signatures
4. File a pull request for any change that requires changes to our documentation at our documentation repo

---

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)
6. I have checked that another pull request for this purpose does not exist.
7. I have considered, and confirmed that this submission will be valuable to others.
8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
9. I give this submission freely, and claim no ownership to its content.

---

• I have read the above and my PR is ready for review. Check this box to confirm

[yubiuser]

I agree with your reasoning.
But would like to get feedback from @DL6ER because I think he initially choose the colors

[XhmikosR]

It's just that green and red are used across the UI for good and bad meaning. So, in these 2 cases, we basically need a neutral color like the groups and clients labels.

[DL6ER]

Well, yes, but we are not replacing green and red, we are replacing blue and orange which do not have any such meaning here.

master

your branch

Personally, I like the tiny bit of more different colors on the existing coloring scheme more, but there is surely some "I am just used to it being this way" bias in here.

[rdwebdesign]

I don't see this as a case of differentiate block and allow items.
It is just a design choice using colors to differentiate 2 counters: one blue, one yellow.

In this case I think using 2 colors are better than using the same color for both items. I think we can leave this as it is in master.

[XhmikosR]

Too many colors is not good in general. The colors are supposed to have a meaning. Orange as you say is the warning one.

These counters are not warning ones. They are just informative like the rest of the counters.

But anyway...

[rdwebdesign]

I really don't think we are using too many colors. The same colors used on the dashboard top boxes and those boxes colors aren't really tied to a specific meaning.

Sometimes different colors are just used to differentiate items. I really don't think we need this change.

[XhmikosR]

Sorry, you are wrong. The more colors you use the more you create a confusing UI. Each color should adhere to a meaning. It's not the 2000s.

I give up on this since you clearly can't see my point, but it's the wrong decision one more time.