Skip to content

header_authenticated.lp: add the hostname li only if it's greater t… #3501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jun 2, 2025

…han zero

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@XhmikosR XhmikosR marked this pull request as ready for review June 2, 2025 14:12
@XhmikosR XhmikosR requested a review from a team as a code owner June 2, 2025 14:12
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jun 4, 2025

BTW if hostname can be empty I guess we should guard the addition in settings-system too.

EDIT: it's already guarded but the check is different. What's the correct one? Can this be an empty string or not?

@yubiuser
Copy link
Member

yubiuser commented Jun 9, 2025

It should not, but users do crazy things ... #3401

@XhmikosR
Copy link
Contributor Author

OK then, I guess we better leave this as is then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants