Bind address to new element instead of raw HTML construction

[DL6ER]

What does this implement/fix?

Fix incorrectly doubly-escaped links. This is a follow-up on the abandoned #3552

Can be tested by adding the list

https://raw.githubusercontent.com/DandelionSprout/adfilt/master/Alternate%20versions%20Anti-Malware%20List/AntiMalwareHosts.txt

and seeing that the click-link does not work on current development.

---

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)

Checklist:

• The code change is tested and works locally.
• I based my code and PRs against the repositories development branch.
• I signed off all commits. Pi-hole enforces the DCO for all contributions
• I signed all my commits. Pi-hole requires signatures to verify authorship
• I have read the above and my PR is ready for review.

[yubiuser]

Is this expected?

---

Your fix works. However, I like the idea from #3552 where we had a function that checks if a string is encoded or not and performs encoding if necessary. I still think, this could be useful in other places as well.

[DL6ER]

Yes, this is expected and it has been like that before. The idea is to use a (reversible) encoded form of the element itself as identifier so we don't need to keep a list id <-> url up-to-date while the table is being modified.

I still think, this could be useful in other places as well.

But we agreed on the add-another-icons-framework that we should not add new things without applications for them :-) Here, we exactly know that there is no escaping to be done, hence, we don't do it.

[yubiuser]

add-another-icons-framework that we should not add new things without applications for them

Ok, convinced. It might have been me who set this requirement....