Add deprecations on incorrect class names #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extending it the correct class
remkobrenters
approved these changes
Mar 25, 2025
Collaborator
|
I think this is a very good step forward. The deprecation error messages are a nice cherry on top. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #675 deprecating the remaining classes pointed out in my description. Since the changes have been merged uncommented I've taken a leap of faith that these would be okay as well (let me know if you think differently).
Copilot summary:
This pull request includes several changes to deprecate classes with invalid naming conventions and replace them with correctly named classes. Each deprecated class now triggers a deprecation warning and extends the new class. The most important changes include the deprecation of classes such as
Deleted,DocumentCategorie,DocumentsAttachment,HrmDivision, andInventoryItemWarehouse.Deprecation of classes with invalid naming conventions:
src/Picqer/Financials/Exact/Deleted.php: Deprecated theDeletedclass and replaced it withSyncDeleted. Added a deprecation warning. ([src/Picqer/Financials/Exact/Deleted.phpR5-L34](https://github.com/picqer/exact-php-client/pull/678/files#diff-7de890c6ea205ecc2f67f927313a614145a5b301b8b1c32e8d7bc3e293072e91R5-L34))src/Picqer/Financials/Exact/DocumentCategorie.php: Deprecated theDocumentCategorieclass and replaced it withDocumentCategory. Added a deprecation warning. ([src/Picqer/Financials/Exact/DocumentCategorie.phpR5-L27](https://github.com/picqer/exact-php-client/pull/678/files#diff-c65e5aa321acc813022346e486175d6a1bafe17fd3fdabe8993fe739855473cbR5-L27))src/Picqer/Financials/Exact/DocumentsAttachment.php: Deprecated theDocumentsAttachmentclass and replaced it withCrmDocumentAttachment. Added a deprecation warning. ([src/Picqer/Financials/Exact/DocumentsAttachment.phpR5-L28](https://github.com/picqer/exact-php-client/pull/678/files#diff-8f0ba86d4c7e3b208bba60e79655922eeee8c8b101af6e1c8e64b3b68d0e23a1R5-L28))src/Picqer/Financials/Exact/HrmDivision.php: Deprecated theHrmDivisionclass and replaced it withDivision. Added a deprecation warning. ([src/Picqer/Financials/Exact/HrmDivision.phpR5-L86](https://github.com/picqer/exact-php-client/pull/678/files#diff-bf69e63038bd26c58e847931c9acc6c20c31729e9651441aa8f295c65933952dR5-L86))src/Picqer/Financials/Exact/InventoryItemWarehouse.php: Deprecated theInventoryItemWarehouseclass and replaced it withSyncInventoryItemWarehouse. Added a deprecation warning. ([src/Picqer/Financials/Exact/InventoryItemWarehouse.phpR5-L72](https://github.com/picqer/exact-php-client/pull/678/files#diff-9c8e05d1c24f0951e2042bd457c605107304a746834ad3144e069dfe94d046f2R5-L72))