Add spi bus speed to board initialization #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2018 22:50
Fix setup to require modified pifacecommon
tompreston
reviewed
Sep 18, 2018
| git+git://github.com/avishayp/pifacecommon |
There was a problem hiding this comment.
This should probably go back to pifacecommon or setup.py should be updated. I'm not sure which is the preferred method of specifying dependencies these days.
|
That’s a leftover from my tests and should not be merged.
On Tue, 18 Sep 2018 at 12:02 Thomas Preston ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In requirements.txt
<#9 (comment)>:
> \ No newline at end of file
+git+git://github.com/avishayp/pifacecommon
This should probably go back to pifacecommon or setup.py should be
updated. I'm not sure which is the preferred method of specifying
dependencies these days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACEi1P-GIj7YIeftOGCqygEb6VMxyPPjks5ucLa3gaJpZM4WsbO5>
.
--
|
|
Okay, thanks for the update! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpi3 has different spi bus speed, due to a change in core clock frequency. As a result, the piface relay plus board throws "error not detected".
requires piface/pifacecommon#26
Will fix the likes of #8