Skip to content

Show indicator on all sliders #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

CoryCharlton
Copy link

@CoryCharlton CoryCharlton commented Dec 17, 2024

Description

Set showIndicator to true on all usages of the SliderItem

Related Issue

This PR fixes or closes issue: fixes #1608

Motivation and Context

The current slider behavior is inconsistent. Additionally the lack of a slider can make mobile user challenging when the track and background have similar colors with little contrast.

How Has This Been Tested

Locally in provided Docker configuration.

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚙️ Tech (code style improvement, performance improvement or dependencies bump)
  • 📚 Documentation (fix or addition in the documentation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

@piitaya
Copy link
Owner

piitaya commented Feb 28, 2025

Thank for the contribution.
I'm closing the PR as the slider indicator should look like this instead of the white cursor in the regular slider.

CleanShot 2025-02-28 at 17 45 19@2x

@piitaya piitaya closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Not all sliders show indicators
2 participants