Skip to content

Conversation

@pascal-sauer
Copy link
Contributor

No description provided.

@pascal-sauer pascal-sauer marked this pull request as draft March 20, 2025 13:00
@tonnrueter
Copy link
Contributor

tonnrueter commented Mar 20, 2025

Seems to work 🤷 Some notes:

  • In order for this to be propagated to all other PIAM projects we'd need to edit inst/extdata/check.yaml

  • This section

    - uses: actions/setup-python@v5
     with:
       python-version: 3.9
    
    - name: Install python dependencies if applicable
     run: |
       [ -f requirements.txt ] && python -m pip install --upgrade pip wheel || true
       [ -f requirements.txt ] && pip install -r requirements.txt || true

    oughta go since from what I understand this installs Python dependencies defined in a requirements.txt file in a Python v3.9 if said file is present in the repo which seems unnecessary for our R-based ecosystem. Also Python v3.9 seems kinda arbitrary since we (REMIND) requires >=3.11

  • The pre-commit run --show-diff-on-failure --color=always --all-files section will run regardless since the GHAs run in a Ubuntu instance that comes with Python (albeit of unknown version). It uses the inst/extdata/pre-commit-config.yaml file to enforce useful coding etiquette standards

@pascal-sauer pascal-sauer marked this pull request as ready for review March 20, 2025 13:42
@pascal-sauer pascal-sauer requested a review from tonnrueter March 21, 2025 10:18
Copy link
Contributor

@tonnrueter tonnrueter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for inst/extdata/pikPiamPackages. Can't tell if that's how it oughta be

@tonnrueter tonnrueter self-requested a review March 21, 2025 17:11
@tonnrueter tonnrueter merged commit 4674f4e into pik-piam:master Mar 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants