Skip to content

Conversation

@pascal-sauer
Copy link
Contributor

@pascal-sauer pascal-sauer commented Jul 29, 2025

  • skip ci on draft PRs

@pascal-sauer pascal-sauer requested a review from codeZeilen July 29, 2025 12:14
@pascal-sauer pascal-sauer marked this pull request as ready for review July 29, 2025 12:14
@pascal-sauer pascal-sauer merged commit c49841d into pik-piam:master Jul 29, 2025
2 checks passed
@codeZeilen
Copy link
Member

Funny thing, on draft PRs that are marked ready for review but do not receive another commit (which is probably most often the case when marking a PR as ready-for-review), the action is not run again.

I think we do need:

  pull_request:
    types: [opened, synchronize, reopened, ready_for_review]
    branches: ...

in addition to ensure that when the state of the PR changes, GH actions are run again.

@codeZeilen
Copy link
Member

I will open another PR to add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants