Skip to content

Commit

Permalink
fixed tests
Browse files Browse the repository at this point in the history
updated cran comments
  • Loading branch information
tscheypidi committed May 2, 2023
1 parent 13ae8c0 commit ef26d3a
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 6 deletions.
29 changes: 26 additions & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,27 @@
## CHANGES
* fixed issue with tar gzip compression on Solaris systems
* fixed rare sorting issue on MACOS system (different file order compared to other systems)
* fixed rounding issue in tests on ATLAS system
* fixed a test issue incorrectly detecting two paths as different under Windows (due to different lower/upper cases in the returned paths)
* changed default cachetype from "rev" to "def" (shared cache folder instead of separate cache folders)
* added limited caching support for terra objects

## Test environments
* local R installation, R 4.1.2
* rhub Ubuntu Linux 20.04.1 LTS, R-release, GCC
* rhub Windows Server 2022, R-devel, 64 bit
* rhub Fedora Linux, R-devel, clang, gfortran

## R CMD check results

Rhub Windows devel:
* checking for non-standard things in the check directory ... NOTE
Found the following files/directories:
''NULL''
* checking for detritus in the temp directory ... NOTE
Found the following files/directories:
'lastMiKTeXException'

Rhub Fedora and Ubuntu Linux:

* checking HTML version of manual ... NOTE
Skipping checking HTML validation: no command 'tidy' found

To my understanding the issue on Rhub Windows devel seems to be a problem with the local MikTex installation on the server as it does not occur on other test machines and as I could not reproduce the problem myself. In addition, there are no direct calls to miktex so that the temporary directory seems to be created by some other tools. Similarly, the issue on Linux seems to be a problem of the test machines unrelated to the package.
6 changes: 3 additions & 3 deletions tests/testthat/test-caching.R
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ test_that("terra objects can be cached", {
expect_message(a <- readSource("SingleSource"), "writing cache")
expect_message(b <- readSource("SingleSource"), "loading cache")
# converting to data frame because terra::sources is different
expect_identical(terra::as.data.frame(a, xy = TRUE),
expect_equal(terra::as.data.frame(a, xy = TRUE),
terra::as.data.frame(b, xy = TRUE))
expect_identical(names(a), names(b))

Expand All @@ -137,7 +137,7 @@ test_that("terra objects can be cached", {
expect_message(a <- readSource("InMemory"), "writing cache")
expect_message(b <- readSource("InMemory"), "loading cache")
# converting to data frame because terra::sources is different
expect_identical(terra::as.data.frame(a, xy = TRUE),
expect_equal(terra::as.data.frame(a, xy = TRUE),
terra::as.data.frame(b, xy = TRUE))
expect_identical(names(a), names(b))

Expand All @@ -155,7 +155,7 @@ test_that("terra objects can be cached", {
expect_message(a <- readSource("MultiSource"), "writing cache")
expect_message(b <- readSource("MultiSource"), "loading cache")
# converting to data frame because terra::sources is different
expect_identical(terra::as.data.frame(a, xy = TRUE),
expect_equal(terra::as.data.frame(a, xy = TRUE),
terra::as.data.frame(b, xy = TRUE))
expect_identical(names(a), names(b))

Expand Down

0 comments on commit ef26d3a

Please sign in to comment.