Skip to content

Conversation

laurinks
Copy link
Collaborator

@laurinks laurinks commented Sep 30, 2025

Purpose of this PR

  1. Add comments to summation checks for ScenarioMIP to indicate why certain checks currently fail.
  2. Fix unit checks for BTC2 mapping.

Checklist:

  • I did not use Excel to open csv files or checked that no side-effects occur (changed values, many new quotation marks, …)
  • I added any renamed piam_variable to renamed_piam_variables.csv to guarantee backwards compatibility.
  • For REMIND variables, I used |+| notation consistently. This can be achieved automatically with updatePlusUnit().

It is recommended to have a look at the tutorial before submission.

@laurinks laurinks requested a review from flohump September 30, 2025 12:39
Copy link
Contributor

@flohump flohump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the comments and for fixing the unit bugs!

@laurinks laurinks merged commit 962c692 into pik-piam:master Sep 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants