Generic OAuth 2.0 Client: Add client_secret #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardo-a-alves-alb
force-pushed
the
generic-oauth-client_secret
branch
2 times, most recently
from
6841c8a to
1840274
Compare
Author
|
@pilcrowonpaper have you had any chance to look into this PR? I added the parameter as an optional at the end of the constructor so that it isn't a breaking change... If you want something done in another way, feel free to ask for them or even commit directly. Thanks! |
ricardo-a-alves-alb
force-pushed
the
generic-oauth-client_secret
branch
from
61245bc to
44ee6d2
Compare
ricardo-a-alves-alb
force-pushed
the
generic-oauth-client_secret
branch
2 times, most recently
from
af68f93 to
5830594
Compare
Author
|
@pilcrowonpaper Sorry for pinging you... Any news on this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the Generic OAuth 2.0 Client to send a
client_secretparameter on the token related methods.Closes: #297
DO NOT DELETE THIS SECTION.
Thank you for creating a pull request!
If your pull request is just making changes to the docs, please create it against the
mainbranch.If your pull request is making changes to the library source code, please create it against the
nextbranch. If your pull request adds a new feature to the library, please open a new issue first.If you're unsure, you can just create it against the
mainbranch.