Fix missing newlines and add project configuration #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add newlines to 61+ PHP files that were missing them - Includes test files and source files in src/ directory - Follows PHP coding standards requiring files to end with newlines - Excludes vendor directory as specified 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add CLAUDE.md with project guidelines and commands - Add Claude agents configuration directory - Update Claude command files with project-specific instructions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove undefined setGetInheritedValues and getGetInheritedValues methods from Folder, Hardlink, and Link resolver contracts - Update corresponding contract interfaces to match - These methods don't exist in the underlying Pimcore wrapper classes unlike other document types - Resolves 6 PHPStan static analysis errors 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add AudioResolver for Pimcore\Model\Asset\Audio with methods: getList, getByPath, getTypes, create, getById - Add KeyGroupRelationResolver for Pimcore\Model\DataObject\Classificationstore\KeyGroupRelation with methods: create, getByGroupAndKeyId, locateDaoClass - Follow 4-layer architecture pattern with contract interfaces, contract implementations, bundle interfaces, and internal resolvers - Include comprehensive unit tests with proper method exclusions for return type checking - All implementations pass PHPStan level 6 analysis 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Code Quality Fixes
tests/Unit/directoriessrc/directoriesProject Configuration
CLAUDE.mdwith comprehensive development guidelinesNew Hardlink Resolvers
Test Plan
🤖 Generated with Claude Code