Skip to content

Add UserRole Resolver. #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 11, 2025
Merged

Add UserRole Resolver. #95

merged 11 commits into from
Feb 11, 2025

Conversation

herbertroth
Copy link
Member

No description provided.

Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@herbertroth
Copy link
Member Author

This pull request involves significant refactoring and deprecation of methods related to user role management and proxy events. The most important changes include the removal of user role methods from UserResolverContract, the introduction of new UserRoleResolver classes and interfaces, and the deprecation of several proxy-related classes and interfaces.

Refactoring and Deprecation:

Introduction of UserRoleResolver:

Deprecation of Proxy-related Classes and Interfaces:

Copy link

Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments to the deprecation notice... Rest LGTM

@herbertroth herbertroth merged commit a10d451 into 2.x Feb 11, 2025
13 checks passed
@herbertroth herbertroth deleted the Add-userrole-resolver branch February 11, 2025 14:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
@martineiber martineiber added this to the 2.1.0 milestone Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants