Skip to content

[Docs] Align Mercure settings with Symfony Cookie requirements #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

lorextera
Copy link
Contributor

Updated documentation to reflect that the pimcore_studio_backend.mercure_settings.samesite configuration value must be in lowercase, as enforced by the Symfony\Component\HttpFoundation\Cookie class.

Changes in this pull request

This ensures compatibility and prevents potential runtime exceptions due to invalid SameSite values.

Updated documentation to reflect that the `pimcore_studio_backend.mercure_settings.samesite` configuration value must be in lowercase, as enforced by the [Symfony\Component\HttpFoundation\Cookie](https://github.com/symfony/symfony/blob/cd87bdea0633e0a1fa82c07e2fc36ac280cd632a/src/Symfony/Component/HttpFoundation/Cookie.php#L23) class. This ensures compatibility and prevents potential runtime exceptions due to invalid SameSite values.
@martineiber martineiber added this to the next milestone Jun 10, 2025
Copy link

Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thank you

@martineiber martineiber merged commit e374bc4 into pimcore:1.x Jun 10, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants