Skip to content

[Assets] Add document custom thumbnail download and stream endpoints #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 18, 2025
Merged

[Assets] Add document custom thumbnail download and stream endpoints #1284

merged 6 commits into from
Aug 18, 2025

Conversation

lukmzig
Copy link
Contributor

@lukmzig lukmzig commented Aug 14, 2025 •
edited
Loading

Changes in this pull request

Resolves #1257

Additional info

  • add endpoint to download custom thumbnail for document assets
  • add endpoint to stream custom thumbnail for document assets
  • add endpoint to stream thumbnail by name for document assets
  • add endpoint to download thumbnail by name for document assets

@lukmzig lukmzig self-assigned this Aug 14, 2025
@lukmzig
Copy link
Contributor Author

lukmzig commented Aug 14, 2025

@markus-moser could you have a quick look if this is sufficient for the requirements? I added 2 endpoints, so we are able to stream and also download custom thumbnail image for documents

@markus-moser
Copy link
Contributor

@lukmzig Thanks, this is exactly what we need! The only thing whats missing is that we also need the thumbnail name option like here: #1245 Could you please add this endpoint too?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lukmzig lukmzig marked this pull request as ready for review August 18, 2025 08:57
@lukmzig lukmzig requested a review from martineiber August 18, 2025 08:58
martineiber
martineiber approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukmzig lukmzig merged commit 15f0a40 into 1.x Aug 18, 2025
13 checks passed
@lukmzig lukmzig deleted the 1257-assets-add-document-image-thumbnail-endpoint branch August 18, 2025 10:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@martineiber martineiber martineiber approved these changes

Assignees

@lukmzig lukmzig

Labels
New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Assets] Add document image thumbnail endpoint
3 participants
@lukmzig @markus-moser @martineiber