Skip to content

Add checkbox and textarea to field filters #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Corepex
Copy link
Contributor

@Corepex Corepex commented May 26, 2025

Changes in this pull request

Resolves #1532

Additional info

@Corepex Corepex self-assigned this May 26, 2025
@xIrusux
Copy link
Contributor

xIrusux commented May 30, 2025

  • add textarea and checkbox grid cells so they can be viewed
  • add textarea and checkbox filter fields so they can be filtered for
  • segemented dynamic type for checkbox
  • textarea dynamic type
Screencast.from.2025-05-30.14-21-46.webm

@xIrusux xIrusux marked this pull request as ready for review May 30, 2025 12:26
@xIrusux xIrusux requested a review from vin0401 May 30, 2025 12:26
@xIrusux
Copy link
Contributor

xIrusux commented May 30, 2025

raised bug

pimcore/studio-backend-bundle#1122

filtering for checkbox filterValue: false should return all items with the value set to false. As you can see in video it currently does not do that

Copy link

id = 'checkbox'

getFieldFilterType (): string {
return 'system.string'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should work for assets, since he will just fallback to the frontend type "metadata.checkbox".

But not sure how this will behave for data-objects, I guess we need some kind of new filter here:
https://github.com/pimcore/studio-backend-bundle/blob/1.x/doc/03_Grid.md#columnfilter

Something like system.checkbox?
I'm pretty sue @ValeriaMaltseva and @martineiber can help you here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check how this filter behaved on data-objects and let you know!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @martineiber

@xIrusux
Copy link
Contributor

xIrusux commented Jun 4, 2025

@vin0401 all good if I merge then ? and we do the objects work later as discussed

@vin0401
Copy link
Collaborator

vin0401 commented Jun 5, 2025

@xIrusux yes, sure, let's merge it. :)

@xIrusux xIrusux merged commit cfd175a into 1.x Jun 5, 2025
1 check passed
@xIrusux xIrusux deleted the 1532-assets---add-textarea-and-checkbox-type-fields-to-filter-selection branch June 5, 2025 11:03
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
@markus-moser markus-moser added this to the next milestone Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Assets] - add textarea and checkbox type fields to filter selection
5 participants