-
Notifications
You must be signed in to change notification settings - Fork 9
Add checkbox
and textarea
to field filters
#1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkbox
and textarea
to field filters
#1534
Conversation
…ssets---add-textarea-and-checkbox-type-fields-to-filter-selection
Screencast.from.2025-05-30.14-21-46.webm |
raised bug pimcore/studio-backend-bundle#1122 filtering for checkbox filterValue: false should return all items with the value set to false. As you can see in video it currently does not do that |
|
id = 'checkbox' | ||
|
||
getFieldFilterType (): string { | ||
return 'system.string' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should work for assets, since he will just fallback to the frontend type "metadata.checkbox".
But not sure how this will behave for data-objects, I guess we need some kind of new filter here:
https://github.com/pimcore/studio-backend-bundle/blob/1.x/doc/03_Grid.md#columnfilter
Something like system.checkbox?
I'm pretty sue @ValeriaMaltseva and @martineiber can help you here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check how this filter behaved on data-objects and let you know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @martineiber
@vin0401 all good if I merge then ? and we do the objects work later as discussed |
@xIrusux yes, sure, let's merge it. :) |
Changes in this pull request
Resolves #1532
Additional info