Fix CalendarPopUp #1418
Merged
Fix CalendarPopUp #1418
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urwid Commit cf13256c ("Remove deprecated protected getter methods from
the decoration widgets (pimutils#959)") [1] removed the deprecated
_get_base_widget() getter method. Thus, opening the CalendarPopUp when
editing the date or time of an event causes a crash.
Access the base_widget property directly as suggested by the deprecation
warning.
[1] urwid/urwid@cf13256
Fixes pimutils#1413
WhyNotHugo
force-pushed
the
fix-calendar-popup
branch
from
4eacaaa to
3fadf02
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urwid Commit cf13256c ("Remove deprecated protected getter methods from the decoration widgets (#959)") [1] removed the deprecated _get_base_widget() getter method. Thus, opening the CalendarPopUp when editing the date or time of an event causes a crash.
Access the base_widget property directly as suggested by the deprecation warning.
[1] urwid/urwid@cf13256
Fixes #1413