storage/http: expose ignore_uids config parameter#1135
Closed
pacien wants to merge 1 commit intopimutils:mainfrom
Closed
storage/http: expose ignore_uids config parameter#1135pacien wants to merge 1 commit intopimutils:mainfrom
ignore_uids config parameter#1135pacien wants to merge 1 commit intopimutils:mainfrom
Conversation
pacien
force-pushed
the
http-ignore-uids-param
branch
2 times, most recently
from
e6d7d54 to
66cd4a9
Compare
This allows users to choose whether or not to ignore the UIDs coming from WebCAL providers and instead use the item's content hash. This remains the default behaviour. In my case, my provider was generating stable UIDs but was patching the export date in other fields, resulting in the hash of all events changing at each synchronisation, having the opposite effect.
pacien
force-pushed
the
http-ignore-uids-param
branch
from
66cd4a9 to
8f63da6
Compare
Contributor
Author
|
Rebase and fixed merge conflict. |
Member
|
#1136 doesn't address the issue which you're describing? |
Contributor
Author
|
Yes, #1136 covers that problem and more. I'll close this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to choose whether or not to ignore the UIDs coming
from WebCAL providers and instead use the item's content hash. This
remains the default behaviour.
In my case, my provider was generating stable UIDs but was patching the
export date in other fields, resulting in the hash of all events
changing at each synchronisation, having the opposite effect.