-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anc: Fix enable/disable from slave bud #74
Conversation
This PR should be targeted at |
The base branch of a PR can be changed without needing to close and re-open. |
@FintasticMan Yes, this is true. I can't do it myself though. |
I changed the PR target branch, though looks like this wasnt a clean base off that branch. |
I can do it from my end. |
Switching ANC on or off from master bud has always worked since we could just straight up enable it and no command had to be sent. When switching from slave bud we had to send the command to enable or disable it via app_anc_key. Issue is the handling of this request is from app_anc_cmd_receive_process which is not called without APP_ANC being defined. This commit cleans up the way ANC is enabled and also fixes slave bud ANC switching by implementing the actual code path :)
Done, need approval to push. |
a0efcd6
to
f83598d
Compare
Done, discussed with @Haxk20 on channel, and I've updated the PR. |
This looks great, very happy for this fix to go in. |
Switching ANC on or off from master bud has always worked since we could just straight up enable it and no command had to be sent.
When switching from slave bud we had to send the command to enable or disable it via app_anc_key. Issue is the handling of this request is from app_anc_cmd_receive_process which is not called without APP_ANC being defined.
This commit cleans up the way ANC is enabled and also fixes slave bud ANC switching by implementing the actual code path :)
Please note that the ANC testing branch should be rebased on top of main with this commit added.
I did my testing with main merged with anc_testing branch thus why the key_handling.cpp file :)