-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Draft: Feature/fallback-fetchProposals #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atharen
wants to merge
62
commits into
ping-pub:master
Choose a base branch
from
fuel-infrastructure:feature/fallback-fetchProposals
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Draft: Feature/fallback-fetchProposals #633
atharen
wants to merge
62
commits into
ping-pub:master
from
fuel-infrastructure:feature/fallback-fetchProposals
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding fuel changes
Fuel Deployment Changes
Add Fuel testnet config and modify Fuel mainnet config
Update fuel-testnet.json
* Account balance display for vesting accounts - Introduced spendable and locked balance calculations for vesting accounts. - Updated UI to differentiate between total, spendable, and locked balances. - Added logic to detect vesting accounts and load corresponding spendable balances. - Improved overall balance display for both vesting and regular accounts. * Enhance vesting account balance display - Refined balance calculations for vesting accounts to include liquid and locked balances. - Updated UI to reflect new balance categories: Liquid, Vesting, Delegation, Reward, and Unbonding. - Added theoretical vested amount calculation based on vesting schedule. - Improved clarity of balance descriptions and tooltips for better user understanding. * feat(account): Refactor vesting account handling - handling multi-vesting accounts with multiple schedule - UI to display vesting schedule information, including progress. - Refined balance display - Added helper functions for better management of vesting account data. * feat(account): Improve vesting account balances - Balance calculations to leverages spendable and vesting amounts. - Enhanced UI labels for clarity: - 'Locked' to 'Vesting' - 'Liquid' to 'Balance/Spendable'. - Simplified balance rendering for maintainability. * feat(chain): Update fuel mainnet configuration - Reformatted JSON structure for better readability. - Added asset details for FUEL including coingecko_id and logo. - Specified features supported by the fuel mainnet. - Removed redundant asset entry and ensured consistent formatting. * readme: changelog for vesting account changes changes related to support for vesting accounts and spendable balances * fixup! feat(account): Improve vesting account balances * fixup! fixup! feat(account): Improve vesting account balances * fixup! Account balance display for vesting accounts * fixup! Account balance display for vesting accounts * refactor(account): vesting calculations and UI - helper function for vested amounts based on vesting schedules. - theoretical vested amount and total original vesting handling undefined cases. - Streamlined vesting calculations * refactor(account): improve balance calculations with vesting - particularly when vesting details are missing - still not ideal, especially for totalValue, but mildly improved * fixup! refactor(account): improve balance calculations with vesting * refactor(account): enhance balance loading - Introduced a separate function to load balances based on account type. - Improved handling of spendable balances for vesting accounts, with fallback to regular balances on failure. - Streamlined balance calculations in the totalValue computation. * refactor(account): simplify primaryDenom computation
* fix typo in pricemarket chart when clicking the volume tab of the chat, hover tip remains Price, should be Volume * support atom one * fixed address decode issue * remove truncation of blockspeed to more accurately estimate * use toFixed(2) to limit decimals to two places. * bfhevm-testnet * updating rest port to correctly configure api and make it available at the explorer * update widget * fix: class binding for reactive 'kind' variable * add group * fix issue * add wasm query * support extension txs * improve code * fixed issue * chore: fixed issues with Vue 3 component setup * apply wasm execution * add xion chain customizations * improve supply page * update txs type * add ad * enable ad on ping.pub * improve ad banner * add ad size * hide Sponsors * update ad component * disable ad for now * add reference * fix links issue * update color * Account balance display for vesting accounts - Introduced spendable and locked balance calculations for vesting accounts. - Updated UI to differentiate between total, spendable, and locked balances. - Added logic to detect vesting accounts and load corresponding spendable balances. - Improved overall balance display for both vesting and regular accounts. * Enhance vesting account balance display - Refined balance calculations for vesting accounts to include liquid and locked balances. - Updated UI to reflect new balance categories: Liquid, Vesting, Delegation, Reward, and Unbonding. - Added theoretical vested amount calculation based on vesting schedule. - Improved clarity of balance descriptions and tooltips for better user understanding. * feat(account): Refactor vesting account handling - handling multi-vesting accounts with multiple schedule - UI to display vesting schedule information, including progress. - Refined balance display - Added helper functions for better management of vesting account data. * feat(account): Improve vesting account balances - Balance calculations to leverages spendable and vesting amounts. - Enhanced UI labels for clarity: - 'Locked' to 'Vesting' - 'Liquid' to 'Balance/Spendable'. - Simplified balance rendering for maintainability. * feat(chain): Update fuel mainnet configuration - Reformatted JSON structure for better readability. - Added asset details for FUEL including coingecko_id and logo. - Specified features supported by the fuel mainnet. - Removed redundant asset entry and ensured consistent formatting. * readme: changelog for vesting account changes changes related to support for vesting accounts and spendable balances * fixup! feat(account): Improve vesting account balances * fixup! fixup! feat(account): Improve vesting account balances * fixup! Merge remote-tracking branch 'upstream/master' into feature/resync-with-upstream * fixup! Merge remote-tracking branch 'upstream/master' into feature/resync-with-upstream --------- Co-authored-by: cloudaiminer <[email protected]> Co-authored-by: ping <[email protected]> Co-authored-by: Tino Rusch <[email protected]> Co-authored-by: JTG947 <[email protected]> Co-authored-by: Dmitry <[email protected]> Co-authored-by: wizard <[email protected]> Co-authored-by: 2xburnt <[email protected]>
- Updated fetchProposals method to utilize cache and handle fallback logic for sequential proposal fetching. - Added caching mechanism for government proposals to improve performance and reduce redundant API calls.
- Proposal fetching using Promise.all to reduce redundant API calls.
- caching moved to govCache for readability
- Introduced separate TTL constants for data and request caching. - isExpired method to check cached request validity - manages proposal fetching based on freshness.
This reverts commit 709510e.
- easier to distinguish with upstream
This reverts commit 38694fb.
- Introduced a new TTL for non-complete proposals, allowing for a 1-minute cache duration. - Added a method to determine TTL based on proposal status, ensuring completed proposals (status 3 or 4) never expire from the cache.
- Introduced a fallback data banner in the governance component to inform users when fallback data is being used. - Updated internationalization files to include translations for the fallback data notice in multiple languages. - Enhanced the fallback logic to return a flag indicating whether fallback data is in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fallback whenever proposals fail to be retrieved in batch.