-
Notifications
You must be signed in to change notification settings - Fork 699
add release notes v9.0.0 - bugfix part #21033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/preview-release-notes
Are you sure you want to change the base?
add release notes v9.0.0 - bugfix part #21033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello, Gemini here. This pull request, authored by hfxsd, focuses on updating the release notes for TiDB v9.0.0. Based on the title and the changes presented, the primary goal appears to be preparing or adjusting the structure within the releases/release-9.0.0.md
file, specifically within the 'Improvements' and 'Bug fixes' sections. The changes involve removing placeholder lines that listed various components and tools, likely in anticipation of adding the actual detailed release note entries.
Highlights
- Release Notes Structure Update: The pull request modifies the
releases/release-9.0.0.md
file to refine the structure under the 'Improvements' and 'Bug fixes' sections by removing placeholder component lists.
Changelog
- releases/release-9.0.0.md
- Removed placeholder lines listing components (TiDB, TiKV, PD, TiFlash, Tools) under the 'Improvements' section (lines 365-377 in the original file).
- Removed placeholder lines listing components and tools (TiDB, TiKV, PD, TiFlash, Tools, BR, TiCDC, TiDB Lightning) under the 'Bug fixes' section (lines 381-395 in the original file).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes placeholder content from the "Improvements" and "Bug fixes" sections of the v9.0.0 release notes. This cleanup is helpful if the content for these sections is not yet ready or will be added in subsequent PRs. My review focuses on the Markdown formatting of the resulting document, ensuring it aligns with the provided style guide.
Summary of Findings
- Markdown Formatting: Blank Lines: There are instances of multiple blank lines after section headings (## Improvements, ## Bug fixes). The style guide (line 38) recommends a single blank line after headings.
- Markdown Formatting: Trailing Whitespace: Line 366 contains trailing whitespace, which should ideally be removed for clean formatting.
Merge Readiness
The changes in this PR are straightforward removals of placeholder content. The suggested formatting adjustments are minor. Once these are addressed, the PR should be in good shape. Please note that I am not authorized to approve pull requests; this feedback is for your consideration and for other reviewers.
releases/release-9.0.0.md
Outdated
|
||
+ TiKV | ||
|
||
+ PD | ||
|
||
+ TiFlash | ||
|
||
+ Tools | ||
|
||
+ Backup & Restore (BR) | ||
|
||
+ TiDB Data Migration (DM) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are a couple of extra blank lines here, and line 366 also contains trailing whitespace. To maintain consistent formatting and readability, could we reduce this to a single blank line after the ## Improvements
heading? 1
Style Guide References
Footnotes
releases/release-9.0.0.md
Outdated
|
||
+ TiDB Lightning | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appear to be a few extra blank lines between the ## Bug fixes
heading and the ## Performance test
heading. Would it be possible to reduce these to a single blank line to adhere to the style guide? 1
Style Guide References
Footnotes
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hfxsd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?