Skip to content

style: alert markdown Note section #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

style: alert markdown Note section #1778

wants to merge 2 commits into from

Conversation

guspan-tanadi
Copy link

Formatting Note area section through current flavored markdown.

@ti-chi-bot ti-chi-bot bot requested a review from Renkai April 11, 2025 12:46
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deardrops for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2025

Welcome @guspan-tanadi! It looks like this is your first PR to pingcap/tidb-dashboard 🎉

@ti-chi-bot ti-chi-bot bot added the size/XS label Apr 11, 2025
baurine
baurine reviewed Apr 28, 2025
View reviewed changes
CONTRIBUTING.md
@@ -22,7 +22,7 @@ curl --proto '=https' --tlsv1.2 -sSf https://tiup-mirrors.pingcap.com/install.sh

Declare the global environment variable:

> **Note:**
> [!Note]
Copy link
Collaborator

@baurine baurine Apr 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it looks like after rendering? I don't see it has any special style.

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style look as shown by related branch link.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baurine baurine baurine left review comments

@Renkai Renkai Awaiting requested review from Renkai

Assignees
No one assigned
Labels
area/frontend size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guspan-tanadi @CLAassistant @baurine