Skip to content

chore: refine shared code and fix too long sql #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2025
Merged

chore: refine shared code and fix too long sql #1799

merged 4 commits into from
Jun 30, 2025

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Jun 30, 2025

This PR cherry-pick changes from release-6.5 branch.

This PR includes 3 major tidb-dashboard changes:

  1. truncate too long sql text for sql statement & slow query list to improve performance
  2. add 1 year, custom, no expiration options for share code to login, required by client
  3. add read-only mode for diagnose/manual profiling/debug data features, required by client

Cherry-picked PRs: #1785 #1788 #1786

baurine and others added 4 commits June 30, 2025 16:45
@baurine
fix(diagnosis): truncate sql text to avoid long sql text (#1785)
fca52b1
@baurine
chore(session): refine share code (#1786)
6563406 
* fix(diagnosis): truncate sql text to avoid long sql text

* feat(session): support custom expiration and no expiration

* feat(session): add read-only for some features
@baurine
fix(diagnosis): truncate long sql in frontend side to avoid page hang (…
7f31a76 
…#1788)
@baurine
chore: format code
063c443
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign baurine for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from Renkai June 30, 2025 08:54
@ti-chi-bot ti-chi-bot bot added the size/L label Jun 30, 2025
@baurine baurine merged commit e1f8338 into master Jun 30, 2025
10 of 11 checks passed
@baurine baurine deleted the chore/refine-shared-code-fix-too-long-sql branch June 30, 2025 09:09
@baurine baurine mentioned this pull request Jun 30, 2025
Merged
This was referenced Jul 14, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Renkai Renkai Awaiting requested review from Renkai

Assignees
No one assigned
Labels
area/frontend size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@baurine