Limit proxy's memory from TiFlash's side (#408) #425
Conversation
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
|
No idea why the default value of |
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
| assert_eq!(config.raft_store.evict_cache_on_memory_ratio, 0.1); | ||
| assert_eq!(config.memory_usage_high_water, 0.9); | ||
| // Seems #244 doesn't goes into this branch. | ||
| assert_eq!(config.server.reject_messages_on_memory_ratio, 0.2); |
| @@ -396,7 +396,7 @@ impl Default for Config { | |||
| apply_yield_duration: ReadableDuration::millis(500), | |||
| apply_yield_write_size: ReadableSize::kb(32), | |||
| perf_level: PerfLevel::Uninitialized, | |||
| evict_cache_on_memory_ratio: 0.0, | |||
| evict_cache_on_memory_ratio: 0.1, | |||
There was a problem hiding this comment.
It is currently in 0.1 in tikv release-6.5. We just modify here, so even if we merged upstream later, there is no difference.
|
@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JaySon-Huang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cherry-pick #408 to 6.5
What is changed and how it works?
Issue Number: Close tiflash#9745
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note