Skip to content

Update examples #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Conversation

stephenlthorn
Copy link

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • [X ] No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 May 2, 2025 13:43
@sre-bot
Copy link
Contributor

sre-bot commented May 2, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

ti-chi-bot bot commented May 2, 2025

Welcome @stephenlthorn! It looks like this is your first PR to pingcap/tidb-operator 🎉

@ti-chi-bot ti-chi-bot bot added the size/XXL label May 2, 2025
csuzhangxc
csuzhangxc previously approved these changes Jun 27, 2025
Comment on lines 9 to 10
## tidb cluster to be monitored
## ** now only support monitoring one tidb cluster **
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 27, 2025
Copy link
Contributor

ti-chi-bot bot commented Jun 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-27 07:05:43.419333852 +0000 UTC m=+1032996.142512834: ☑️ agreed by csuzhangxc.
  • 2025-06-27 07:14:42.310238659 +0000 UTC m=+1033535.033417641: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Jun 27, 2025

New changes are detected. LGTM label has been removed.

Copy link
Contributor

ti-chi-bot bot commented Jun 27, 2025

@stephenlthorn: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc csuzhangxc dismissed their stale review June 27, 2025 09:12

mistake

Copy link
Contributor

ti-chi-bot bot commented Jun 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign husharp for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the approved label Jun 27, 2025
@stephenlthorn
Copy link
Author

All requested changes are in. Could a maintainer please /ok-to-test and review?

Copy link
Author

@stephenlthorn stephenlthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants