Skip to content

fix: field name error for monitor-grafana-secret example. #6208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ben-wangz
Copy link

What problem does this PR solve?

fix the field name error for monitor-grafana-secret example.

What is changed and how does it work?

according to https://github.com/pingcap/tidb-operator/blob/master/pkg/apis/pingcap/v1alpha1/tidbmonitor_types.go#L273 (line 273 and 277), the field names should be usernameSecret and passwordSecret

Code changes

  • Has Go code change
  • [ x] Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • [x ] Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from shonge May 20, 2025 09:29
Copy link
Contributor

ti-chi-bot bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign linuxgit for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

ti-chi-bot bot commented May 20, 2025

Welcome @ben-wangz! It looks like this is your first PR to pingcap/tidb-operator 🎉

@ben-wangz ben-wangz changed the title fix: field name error fix: field name error for monitor-grafana-secret example. May 20, 2025
@ti-chi-bot ti-chi-bot bot added the size/XS label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants