Skip to content

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 7, 2025

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zimulala for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge November 7, 2025 12:48
@dveeden dveeden requested a review from wuhuizuo November 7, 2025 12:48
@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 7, 2025
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Nov 7, 2025

/cc @csuzhangxc @liubog2008

@ti-chi-bot ti-chi-bot bot requested review from csuzhangxc and liubog2008 November 7, 2025 12:59
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Nov 7, 2025

The ci job is so weak. 😭

--- FAIL: TestPDPodSyncForLeaderTransfer (241.14s)
    --- FAIL: TestPDPodSyncForLeaderTransfer/transfer_leader_only (60.01s)
        pod_control_test.go:636: 
            Timed out after 60.001s.
            Expected success, but got an error:
                <*errors.StatusError | 0xc00001b2c0>: 
                tidbcluster.pingcap.com "test-pd" not found
                {
                    ErrStatus: {
                        TypeMeta: {Kind: "", APIVersion: ""},
                        ListMeta: {
                            SelfLink: "",
                            ResourceVersion: "",
                            Continue: "",
                            RemainingItemCount: nil,
                        },
                        Status: "Failure",
                        Message: "tidbcluster.pingcap.com \"test-pd\" not found",
                        Reason: "NotFound",
                        Details: {Name: "test-pd", Group: "pingcap.com", Kind: "tidbcluster", UID: "", Causes: nil, RetryAfterSeconds: 0},
                        Code: 404,
                    },
                }

@dveeden
Copy link
Contributor Author

dveeden commented Nov 7, 2025

It didn't run the "Upload test coverage" in pull (test), possibly due to the TestPDPodSyncForLeaderTransfer failure. That means it didn't really try the changes in this PR yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants