Skip to content

CI: Upgrade codecov-action#6537

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-1.xfrom
dveeden:codecov_action
Dec 16, 2025
Merged

CI: Upgrade codecov-action#6537
ti-chi-bot[bot] merged 2 commits intopingcap:release-1.xfrom
dveeden:codecov_action

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 7, 2025

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

@ti-chi-bot ti-chi-bot bot requested a review from shonge November 7, 2025 12:48
@dveeden dveeden requested a review from wuhuizuo November 7, 2025 12:48
@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 7, 2025
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Nov 7, 2025

/cc @csuzhangxc @liubog2008

@ti-chi-bot ti-chi-bot bot requested review from csuzhangxc and liubog2008 November 7, 2025 12:59
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Nov 7, 2025

The ci job is so weak. 😭

--- FAIL: TestPDPodSyncForLeaderTransfer (241.14s)
    --- FAIL: TestPDPodSyncForLeaderTransfer/transfer_leader_only (60.01s)
        pod_control_test.go:636: 
            Timed out after 60.001s.
            Expected success, but got an error:
                <*errors.StatusError | 0xc00001b2c0>: 
                tidbcluster.pingcap.com "test-pd" not found
                {
                    ErrStatus: {
                        TypeMeta: {Kind: "", APIVersion: ""},
                        ListMeta: {
                            SelfLink: "",
                            ResourceVersion: "",
                            Continue: "",
                            RemainingItemCount: nil,
                        },
                        Status: "Failure",
                        Message: "tidbcluster.pingcap.com \"test-pd\" not found",
                        Reason: "NotFound",
                        Details: {Name: "test-pd", Group: "pingcap.com", Kind: "tidbcluster", UID: "", Causes: nil, RetryAfterSeconds: 0},
                        Code: 404,
                    },
                }

@dveeden
Copy link
Contributor Author

dveeden commented Nov 7, 2025

It didn't run the "Upload test coverage" in pull (test), possibly due to the TestPDPodSyncForLeaderTransfer failure. That means it didn't really try the changes in this PR yet.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 12, 2025

/retest

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-1.x@a3e9926). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.x    #6537   +/-   ##
==============================================
  Coverage               ?   62.89%           
==============================================
  Files                  ?      267           
  Lines                  ?    39334           
  Branches               ?        0           
==============================================
  Hits                   ?    24739           
  Misses                 ?    12397           
  Partials               ?     2198           
Flag Coverage Δ
e2e 29.54% <ø> (?)
unittest 57.55% <ø> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liubog2008 liubog2008 changed the base branch from master to release-1.x December 16, 2025 10:30
@liubog2008
Copy link
Member

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 16, 2025

@liubog2008: No presubmit jobs available for pingcap/[email protected]

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@liubog2008
Copy link
Member

/run-all-tests

@liubog2008
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-16 10:40:42.875355216 +0000 UTC m=+1555987.689132788: ☑️ agreed by liubog2008.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liubog2008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 16, 2025
@ti-chi-bot ti-chi-bot bot merged commit 2359588 into pingcap:release-1.x Dec 16, 2025
7 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants