-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: merge global stats even if some partition stats are missing (#41176) #49471
statistics: merge global stats even if some partition stats are missing (#41176) #49471
Conversation
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
112c74c
to
920a414
Compare
[LGTM Timeline notifier]Timeline:
|
/retest |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
5b5485c
to
27a6353
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test unit-test |
@qw4990: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #49471 +/- ##
================================================
Coverage ? 73.6624%
================================================
Files ? 1097
Lines ? 352569
Branches ? 0
================================================
Hits ? 259711
Misses ? 76149
Partials ? 16709 |
This is an automated cherry-pick of #41176
What problem does this PR solve?
Issue Number: ref #38999
Problem Summary:
What is changed and how it works?
Introduce a system variable
tidb_skip_missing_partition_stats
, whose default value ison
. Iftidb_skip_missing_partition_stats
turns on, merging global stats would skip partitions whose stats are missing rather than fail.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.