executor: fix admin check return wrong result for index containing generated columns

[joechenrh]

What problem does this PR solve?

Issue Number: close #57153

Problem Summary:

What changed and how does it work?

When generating index SQL under fast admin check mode, use the correct names for virtual columns.

More specifically, only use GeneratedExprString when column is hidden.

tidb/pkg/executor/check_table_index.go

Lines 377 to 380 in 7fe6cfe

	if tblCol.IsVirtualGenerated() && tblCol.Hidden {
	indexColNames[i] = tblCol.GeneratedExprString
	} else {
	indexColNames[i] = ColumnName(col.Name.O)

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.2264%. Comparing base (6004c3e) to head (7fe6cfe).
Report is 14 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #57152         +/-   ##
=================================================
- Coverage   73.0078%   56.2264%   -16.7815%     
=================================================
  Files          1657       1783        +126     
  Lines        457652     637218     +179566     
=================================================
+ Hits         334122     358285      +24163     
- Misses       103015     254761     +151746     
- Partials      20515      24172       +3657     

Flag	Coverage Δ
integration	36.9652% <78.0000%> (?)
unit	72.2921% <94.0000%> (+0.0033%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	52.2766% <ø> (+6.5575%)	⬆️

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-07 08:36:01.510771419 +0000 UTC m=+1116474.349926950: ☑️ agreed by wjhuang2016.