Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57067

What problem does this PR solve?

Issue Number: close #57137

This issue is because a trigger action will be sent to the timer worker via the chan:

select {
case <-rt.ctx.Done():
return false
case worker.ch <- req:
rt.cache.setTimerProcStatus(timer.ID, procTriggering, eventID)
default:
if busyWorkers == nil {
busyWorkers = make(map[string]struct{})
}
busyWorkers[timer.HookClass] = struct{}{}
retryTimerIDs = append(retryTimerIDs, timer.ID)
retryTimerKeys = append(retryTimerKeys, fmt.Sprintf("[%s] %s", timer.Namespace, timer.Key))
}
return true
})

If the chan is full, it will fail and retry after a while. However, some tables always have lower priorities even if they are not triggered for a long time.

What changed and how does it work?

reorder timers by nextEventTime before sending them to workers to make sure the timer which has a max delay will be handled first to avoid starvation

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

ttl: fix some times TTL job can not be scheduled when there are a lot of TTL tables.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 6, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2024
@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@5518942). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #57157   +/-   ##
================================================
  Coverage               ?   55.7731%           
================================================
  Files                  ?       1777           
  Lines                  ?     635024           
  Branches               ?          0           
================================================
  Hits                   ?     354173           
  Misses                 ?     257380           
  Partials               ?      23471           
Flag Coverage Δ
integration 35.7083% <12.1212%> (?)
unit 72.5361% <90.9090%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 46.4142% <0.0000%> (?)

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-06 05:45:37.374626105 +0000 UTC m=+1019850.213781651: ☑️ agreed by lcwangchao.
  • 2024-11-06 08:42:11.65092543 +0000 UTC m=+1030444.490080971: ☑️ agreed by YangKeao.

@lcwangchao
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot bot merged commit 4fb27d5 into pingcap:release-8.5 Nov 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants